Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-inserting blocks: Minor fixes to address feedback #53183

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Auto-inserting blocks: Minor fixes to address feedback #53183

merged 7 commits into from
Aug 3, 2023

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Jul 31, 2023

What?

Address @dmsnell's feedback on #51449.

Why?

That feedback was received after merging the PR, so a separate PR is needed to address it 🙂

How?

Apply those suggestions.

Testing Instructions

N/A

@ockham ockham self-assigned this Jul 31, 2023
@ockham ockham added [Type] Experimental Experimental feature or API. [Type] Code Quality Issues or PRs that relate to code quality labels Jul 31, 2023
@ockham ockham changed the title Document possible values of relative_position argument Auto-inserting blocks: Minor fixes to address feedback Jul 31, 2023
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/auto-inserting-blocks.php

@ockham ockham removed the [Type] Experimental Experimental feature or API. label Aug 1, 2023
@ockham ockham requested a review from dmsnell August 1, 2023 08:27
@ockham ockham marked this pull request as ready for review August 1, 2023 08:27
@ockham ockham requested a review from spacedmonkey as a code owner August 1, 2023 08:27
@ockham ockham mentioned this pull request Aug 1, 2023
Merged
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Flaky tests detected in 764db10.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5724454136
📝 Reported issues:

dmsnell
dmsnell approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! This clarifies several points of use.

@ockham
Copy link
Contributor Author

ockham commented Aug 3, 2023

Looks like I accidentally committed an unrelated change I had made locally. Reverted in b36efef.

@ockham ockham merged commit 00a1b6e into trunk Aug 3, 2023
@ockham ockham deleted the fix/auto-inserting-block-address-review-comments branch August 3, 2023 09:58
@github-actions github-actions bot added this to the Gutenberg 16.5 milestone Aug 3, 2023
@SiobhyB SiobhyB added the Needs PHP backport Needs PHP backport to Core label Sep 5, 2023
@SiobhyB SiobhyB mentioned this pull request Sep 5, 2023
Closed
86 tasks
@SiobhyB SiobhyB removed the Needs PHP backport Needs PHP backport to Core label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@ockham ockham

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 16.5
Development

Successfully merging this pull request may close these issues.
3 participants
@ockham @dmsnell @SiobhyB